Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override toolchain path #45

Merged
merged 5 commits into from
Feb 5, 2020
Merged

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jan 31, 2020

re: #41

Hardcode tools path in Makefile.arduino to TOOLS=~/.arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/2.5.0-4-b40a506/bin/xtensa-lx106-elf-
Replace TOOLS=../../$(TOOLS) with TOOLS=$(TOOLS) in Makefile.build-lwip2

In case of PlatformIO, toolchain is in a custom dir:

$ env PREFIX=~/.platformio/packages/toolchain-xtensa/ make

IDF has a slightly different idea about pathing:
https://github.com/espressif/esp-idf/blob/f5b82c5b1f33f5287f9b5f1993594bf53755a4f2/Kconfig#L38-L45
I guess it can also be that way, essentially mapping TOOLS=$(PREFIX)

Copy link
Owner

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worksforme Thanks !

@d-a-v d-a-v merged commit b543b1f into d-a-v:master Feb 5, 2020
@mcspr mcspr deleted the toolchain-prefix branch February 5, 2020 15:43
@mcspr
Copy link
Collaborator Author

mcspr commented Feb 5, 2020

Thanks!

At a glance, there are some other relative paths that may be need to be cleaned up too, like patches and includes (both makefile and -I...).
And I also wonder, any interest in adding cmake as a build system instead of raw make?

@d-a-v
Copy link
Owner

d-a-v commented Feb 5, 2020

If you think a cleaning is needed, please propose your fixes.

As of cmake I try to stand far from it (oldschool me ?).
Anyway if you have a CMakeLists.txt we can try to find room for it.

@mcspr
Copy link
Collaborator Author

mcspr commented Feb 6, 2020

So far I was just tinkering with cmake to find out the build process overall:
https://gist.github.com/mcspr/19f8f72649c358323055a80ba5f9b209
I will add another issue / pr when it actually works with multiple flavours of tcp_mss / ipv6 / features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants