Add print of MDNS detail from UDP packet

[hreintke]

As used in debugging of MDNS issue

[d-a-v]

Thanks !
What do you think of factorizing ?

bool mdns = netDump_getDstPort(ethdata) == 5353) || (netDump_getSrcPort(ethdata) == 5353;
bool dns = netDump_getDstPort(ethdata) == 53) || (netDump_getSrcPort(ethdata) == 53;
if (mdns || dns)
{
   if (mdns) out.print(F(" MDNS ")); else out.print(F(" DNS "));
   ...
}

[hreintke]

Yes, Is better and less duplication of code.
But I left it like it is because I am writing a PR which would generalize the functionality of netdump and tcpdump, including easy creation of custom callbacks.
Working on a Proof of concept, which I hope to show you today or tomorrow.

[hreintke]

@d-a-v :
See the netdump_poc.
It is very much work in progress but shows the way I am thinking.

All is one file for now, easier for me to develop.

Application should able to :
netdump.printDump(Serial);
netdump.printDump(Serial, [](NetworkPacket np){ return (np.isIPv4();}
netdump.printDump(Serial, [](NetworkPacket np){ return (np.destIP() == IPAddress(10,0,0,217);}

netdump.setcallback([](NetworkPacket np){ .....}

PS : untested runtime just now, compiles OK

[hreintke]

Updates and first tests.

To use this version.

#include "Netdump_poc"

Netdump* Netdump::self;
Netdump np;

np.printDump(Serial);
netdump.printDump(Serial, [](NetworkPacket np){ return (np.isIPv4();}

np.fileDump works also, not very much tested and needs work for better handling of open/close/write files.

tcpDump : Need to include the code from your

I am on a short trip to France until next thursday or friday -> silence from my side 😄

[d-a-v]

Where that ? :)

[hreintke]

https://www.vaugouard.com
Nice, relaxed, good food, challenging golf course

[hreintke]

@d-a-v
Can you take a look at the current implementation ?
Not fully tested yet, but close to complete functionality

[d-a-v]

Thanks! I will test asap

[d-a-v]

@hreintke I had a look - You changed pretty everything ! - and I'm fine with that, the functional way fits nicely.

I propose several things, you tell me what you think about them:

• Can we agree on a coding style (like Allman, 4 spaces, no tabs or whatever consistent, my vi-like editor looks like broken, even "changes" on gihub - I am currently and painly giving up with my beloved tabs, they are not compatible with open source collaboration)
  (what is your editor, can you set its parameters with an inline directive?)
• My code is in src/Netdump.h (renamed to NetDumpDAV.h) and src/utility
  Yours in src/Netdump
  Can you properly separate your work
  • mine is still Netdump.h, yours could be Netdump2.h
  • or remove mine
• What is your feeling about using lambdas instead of std::bind ?
• Can you add minimal examples
• Your examples/NetDumpTest.cpp is not arduino-right. examples/Netdump2/Netdump2.ino would be a good one

[hreintke]

@d-a-v
Sorry, missed this comment until now.

You changed pretty everything !

I tried to make it as easy as possible for others to use/integrate. in that way it is possible to ask issue submitters to include netdump and report without much trouble

Can we agree on a coding style

Sure, no problem. Do you have an astyle config for your preference. I have the windows version working and can pass everything through that.

My code is in src/Netdump.

I just added my code in a way to evaluate.
Please provide the (directory)structure and I will update it to that.

What is your feeling about using lambdas instead of std::bind ?

I learned this week that there is a difference between the two.
Did my reading and indeed think it is good to update. Will do

Can you add minimal examples
Your examples/NetDumpTest.cpp is not arduino-right

Yes will do, I wanted to wait until you agreed to the implementation,
I am using eclipse (sloeber) and only cpp, no ino.
Think that just changing .cpp to .ino will do the job but am not 100% sure.
Will make .ino examples, please test on your config if they work OK for you too.

[d-a-v]

Sure, no problem. Do you have an astyle config for your preference. I have the windows version working and can pass everything through that.

I took the style we want to be able to integrate in the arduino core. I did not push its results, but you can and push them if that's OK with you.

Did my reading and indeed think it is good to update. Will do

nice. TBH I'm a less than 1y user of lambas/::bind.

Yes will do, I wanted to wait until you agreed to the implementation,

I'll have a second look (I mainly agree anyway)

Will make .ino examples, please test on your config if they work OK for you too.

I will test that today.

[d-a-v]

Again, this is a complete rewrite.
Technically this PR cannot be accepted as is.
But it is worth replacing mine because it is more complete and works differently (lambdas, filters, IPv6, mDNS, scheduled functions)

Why it can't be accepted as is:

• you are not working with arduino, so you can't see the directory structure is not arduino compliant:

  • remove netdumpDAV and the netdump*.cpp in utility/
  • arduino will not read subdirectories (except utility/): move files to src/
  • examples are in examples/sketchname/sketchname.ino (not in examples/theExample.cpp)

• macOS FS lets you mix caps letters, linux makes a difference

  • rename all files with consistency (some are NetDump, others Netdump)

• also:

  • use const type& when passing complex data structures in parameters (like IPAddress, NetDumpAddress, or String) otherwise they will be copied each time they are passed

What I propose:

• clean your fork from other "EspGoodies", only keep Netdump
  (or create a new "Netdump2" repo with your files)
• let me make PRs on your repository
• I will put a link from my repo to yours
• we can later ask (other) esp8266 arduino core maintainers to integrate this library (plainly or as a submodule) into the main repository

What do you think ?

[hreintke]

It's the right way forward.,

I will make the updates as you proposed.
What is your preference, update espgoodies or netdump repo ?

Will not be next week, I'll be off to France again (Jura).