Enforce Header Order for Sendmail #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling HeadersEnforceOrder on the Trx will activate a special workaround for Sendmail to enforce our header ordering. The workaround is to unconditionally delete all existing headers and add (the possibly changed) headers back. This is a significant overhead, so you should only enable this workaround when you really need to enforce your header order. This commit also changes the semantics of InsertBefore* method calls when called for the very first header. Before this the header would have been inserted in-front of the `Received` header of the MTA (position 0) and not in-front of the first header (position 1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround for Sendmail that can enforce the order of the header fields.