Header Unfolding & SetAddressList formatting #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sList() and Text() calls
The old version did not work in modules outside github.com/d--j/go-milter
if the MTA supports it (Sendmail does not) all Header().SetAddressList() and Header().Fields().SetAddressList() calls now set the address list as multi-line header - one address per line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UnfoldedValue() method that returns the unfolded version of a header value.
mail.ParseAddressList cannot handle folded header values so the AddressList() methods would return errors for perfectly valid address lists (that had newlines in them).
While we are at it, we also change the formatting of address lists to encode them as multi-line header fields (one address per line).