Edit all inputs to be more flexible and editable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less tried to use parent's implementation with small changes done mainly in constructors by adding the needed classes, in other places used getControlPrototype and getLabelPrototype instead of creating new Html elements. In some places I added new method for wrappers and separators to add the needed flexibility and added translations.
There are also some TODOs, 2 of which depend on the original Nette/Forms, which I will try to sort out in the future.
Hopefully, I didnt forget about anything. Feedback would be much appreciated.