Skip to content

Commit

Permalink
Use stdin for Selene Lua linter (dense-analysis#4183)
Browse files Browse the repository at this point in the history
When I added Selene as a linter, I wasn't aware it had the option to
process stdin using `-`.
  • Loading branch information
deathlyfrantic authored and cyyever committed Jul 11, 2022
1 parent f9b5a0d commit 96e3143
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions ale_linters/lua/selene.vim
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ call ale#Set('lua_selene_options', '')

function! ale_linters#lua#selene#GetCommand(buffer) abort
return '%e' . ale#Pad(ale#Var(a:buffer, 'lua_selene_options'))
\ . ' --display-style=json %s'
\ . ' --display-style=json -'
endfunction

function! ale_linters#lua#selene#Handle(buffer, lines) abort
Expand Down Expand Up @@ -43,5 +43,4 @@ call ale#linter#Define('lua', {
\ 'executable': {b -> ale#Var(b, 'lua_selene_executable')},
\ 'command': function('ale_linters#lua#selene#GetCommand'),
\ 'callback': 'ale_linters#lua#selene#Handle',
\ 'lint_file': 1,
\})
6 changes: 3 additions & 3 deletions test/linter/test_lua_selene.vader
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ After:
call ale#assert#TearDownLinterTest()

Execute(The lua selene command callback should return the correct default string):
AssertLinter 'selene', ale#Escape('selene') . ' --display-style=json %s'
AssertLinter 'selene', ale#Escape('selene') . ' --display-style=json -'

Execute(The lua selene command callback should let you set options):
let g:ale_lua_selene_options = '--num-threads 2'

AssertLinter 'selene',
\ ale#Escape('selene') . ' --num-threads 2 --display-style=json %s'
\ ale#Escape('selene') . ' --num-threads 2 --display-style=json -'

Execute(The selene executable should be configurable):
let g:ale_lua_selene_executable = 'selene.sh'

AssertLinter 'selene.sh', ale#Escape('selene.sh') . ' --display-style=json %s'
AssertLinter 'selene.sh', ale#Escape('selene.sh') . ' --display-style=json -'

0 comments on commit 96e3143

Please sign in to comment.