Fix dependency resolution issues for non-locked installations of CytoTable in tests #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to resolve a Poetry installation issue with CytoTable where dependency resolutions cause GitHub Actions jobs to hang during the
poetry install
step. I've noticed that this occurs due tobotocore
versioning and resolution challenges and that this can be avoided by specifying abotocore
version within thepyproject.toml
. We saw this occur with an un-locked installation of CytoTable here. I tested a fix for this on a forked branch with an un-locked install here. Cloudpathlib utilizesbotocore
to assist with S3-based compatibility.I'm unsure if this should be persisted to non-development installations of CytoTable. As it stands, this will help pass tests here but it's possible others could run into this as well. The challenge with specifying a version for non-development installations could be that someone might need another version for their work which satisfies cloudpathlib's requirement but is different from what we specify here. Open to thoughts about whether this should be a requirement for installation via PyPI, etc.
Thank you for any thoughts or feedback you may have!
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.