Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IN Carta preset and related compatibility changes + testing #145

Merged
merged 19 commits into from
Jan 19, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jan 16, 2024

Description

This PR adds a preset for use with IN Carta data, some related compatibility changes for use with this preset, and a test which demonstrates the use of this preset and the changes for #136 .

As part of this work, I also opted to update the pre-commit check versions.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Mostly minor comments - one discussion on development design is probably needed (switching to an in-carta-dev branch prior to merging to main).

cytotable/convert.py Show resolved Hide resolved
cytotable/presets.py Show resolved Hide resolved
cytotable/sources.py Show resolved Hide resolved
docs/source/overview.md Outdated Show resolved Hide resolved
@d33bs d33bs added the release-patch Creates a patch release (e.g. `v0.0.1`) label Jan 19, 2024
@d33bs
Copy link
Member Author

d33bs commented Jan 19, 2024

Thank you @gwaybio for the comments and review! Merging this in and kicking off a patch release.

@d33bs d33bs merged commit 562d493 into cytomining:main Jan 19, 2024
7 checks passed
@d33bs d33bs deleted the in-carta-data-integration branch January 19, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Creates a patch release (e.g. `v0.0.1`)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants