Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IN Carta test data from Colas Lab #141

Merged
merged 16 commits into from
Jan 11, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jan 10, 2024

Description

This PR adds test data provided from the Colas Lab to help integrate IN Carta as part of #136 . It is a first step towards building tests, but this PR itself doesn't involve testing and instead only data.

Thanks in advance for any thoughts and feedback you may have!

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple relatively minor comments - overall looks great, glad to see it!

CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Jan 11, 2024

Thank you @gwaybio for the review! Merging this in after changes.

@d33bs d33bs merged commit 75c5822 into cytomining:main Jan 11, 2024
7 checks passed
@d33bs d33bs deleted the in-carta-test-data-colas-lab branch January 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants