Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable fix #22

Merged
merged 2 commits into from
Jul 20, 2016
Merged

Undefined variable fix #22

merged 2 commits into from
Jul 20, 2016

Conversation

spookmango
Copy link
Contributor

content.path was undefined causing a TypeError to be thrown when I ran the sample code.

`content.path` was undefined causing a `TypeError` to be thrown when I ran the sample code.
@cyrilis
Copy link
Owner

cyrilis commented Jul 20, 2016

Hi @spookmango ,
Thank you for your pull-request, but javascript file is generate from coffeescript file( index.js file is generated from index.coffee), could you add the coffeescript file change too ? 😃

Thanks!

@spookmango
Copy link
Contributor Author

Updated it!

@pedrosanta
Copy link
Collaborator

👍 Nice one @spookmango.

@cyrilis cyrilis merged commit 3a41676 into cyrilis:master Jul 20, 2016
@cyrilis
Copy link
Owner

cyrilis commented Jul 20, 2016

Thanks @spookmango !

@spookmango spookmango deleted the patch-1 branch July 24, 2016 18:46
@spookmango
Copy link
Contributor Author

Should there also be a version bump so people who were effected by this can npm update.

I ran my project that used epub-gen on another machine and the bug fixed with this PR was present but not encountered so I suspect (without looking deeply into epub-gen's src) it was situational.

But if I want to give my project to someone who is effected by the bug they'd still have to update epub-gen by hand.

@spookmango spookmango restored the patch-1 branch July 25, 2016 20:37
@pedrosanta
Copy link
Collaborator

Hi @spookmango, yap, we still hadn't released an update. Sorry for the delay. 😀 I'm taking care of that now. Cheers!

@pedrosanta
Copy link
Collaborator

v0.0.14 released, you can go on now and update. 😏 Cheers!

zbrongyaozb pushed a commit to zbrongyaozb/epub-gen that referenced this pull request Aug 2, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants