Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Build version #76

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

benfdking
Copy link
Contributor

@benfdking benfdking commented Apr 13, 2021

  • Aligns the test and release go build version
  • Allows for building for darwin arm64
  • Ran go mod tidy

Not sure about process so please let me know if I have done anything wrongly or missed anything.

- Aligns the test and release go build version
- Allows for building for darwin arm64
- Ran `go mod tidy`
@cyrilgdn cyrilgdn self-requested a review April 14, 2021 07:09
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benfdking Thanks 👍

Do you quickly need a release ? Or could we wait to have a couple of of features before releasing it?

@cyrilgdn cyrilgdn merged commit 89f50c2 into cyrilgdn:master Apr 16, 2021
@benfdking
Copy link
Contributor Author

Hey @cyrilgdn, if it's not too much of a hassle, I'd be really grateful for a quick release 🙏

@benfdking benfdking deleted the updating_go_version branch April 16, 2021 12:45
@cyrilgdn
Copy link
Owner

cyrilgdn commented Apr 23, 2021

@benfdking I'm very sorry I thought I triggered the release but I just realized that I didn't apparently....

So I just released v1.12.1 with the new build version

@benfdking
Copy link
Contributor Author

  1. Please don't appologise!
  2. Thank you for that and all the amazing work around this package! What a nice surprise for the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants