Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building of connection string parameters #47

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix building of connection string parameters #47

merged 1 commit into from
Feb 2, 2021

Conversation

mcwarman
Copy link
Contributor

@mcwarman mcwarman commented Feb 1, 2021

Fixes #36

@stevehipwell
Copy link

@cyrilgdn could we get this merged and built ASAP.

@cyrilgdn
Copy link
Owner

cyrilgdn commented Feb 2, 2021

@mcwarman @stevehipwell Thanks for the PR.

could we get this merged and built ASAP.

Yes I'll review, merge and release it this evening (CEST time)

cyrilgdn
cyrilgdn approved these changes Feb 2, 2021
View reviewed changes
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix (and the associated test 👍 )

I manually tested that certificate work correctly as it was my fear with encode values and it works fine.

@cyrilgdn cyrilgdn merged commit 9cbcf9a into cyrilgdn:master Feb 2, 2021
@cyrilgdn
Copy link
Owner

cyrilgdn commented Feb 2, 2021

@mcwarman @stevehipwell v1.11.1 has been released.

@mcwarman mcwarman deleted the fix-conn-params branch February 3, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrilgdn cyrilgdn cyrilgdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in 1.11.0 sslmode = "disable" does not work properly
3 participants
@mcwarman @stevehipwell @cyrilgdn