-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add resource for subscriptions #244
Conversation
cc @chromko maybe you can have a look at this as you added the publication resource? |
b8ddae9
to
7d3d728
Compare
Hey @cyrilgdn I ran the tests successfully on my local machine, I would be curious if they pass in the CI |
@nicarl Thanks for you work on that 👍
Just triggered them! I'll try to review as soon as possible (hopefully this week-end) |
d.Set("database", databaseName) | ||
d.SetId(generateSubscriptionID(d, databaseName)) | ||
|
||
createSlot, okCreate := d.GetOkExists("create_slot") //nolint:staticcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, did you have time to look at this? |
Hey @cyrilgdn the tests are passing, did you have any time to look at the PR? |
The password is part of the connection string and will be outputed to logs in case of an error. Remove it in case it's present.
7faa84d
to
70f2d5d
Compare
a017791
to
78df550
Compare
fix: hide password on error
Sorry for the absence of response, I was a bit off the project for a while due to lack of time. I'll review it so we can include in the next release, could you just merge master to resolve the conflict (you can revert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work 👍
This has been released in v1.18.0 |
Hey, sorry I did not find time earlier. Thank you for fixing the last details and your work for this provider! 🙇 |
This PR adds the new resource postgresql_publication for managing PostgreSQL publications.
Example:
Key decisions:
conninfo
as one string instead of adding fields forhost
,port
, etc.create_slot
to false as the publisher is on the same database cluster. Otherwise theCREATE
statement will hang. This is a known issue (https://www.postgresql.org/docs/current/sql-createsubscription.html)fix: #238