Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server and user_mapping resources #220

Merged
merged 11 commits into from
Nov 20, 2022
Merged

Add server and user_mapping resources #220

merged 11 commits into from
Nov 20, 2022

Conversation

fabiopaiva
Copy link
Contributor

@fabiopaiva fabiopaiva commented Jun 10, 2022 •
edited
Loading

closes #198

@fabiopaiva
Copy link
Contributor Author

Hi @cyrilgdn
Any idea if this can be merged

cyrilgdn
cyrilgdn requested changes Jul 20, 2022
View reviewed changes
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabiopaiva,

Thanks a lot for this huge work ! Sorry for the delay.

I've just had a look and, apart a couple of minor comments, it seems good to me.
I haven't tested ti but as it's new resources, I trust you and the tests to assert it works fine 👍

postgresql/resource_postgresql_server.go Outdated Show resolved Hide resolved
postgresql/resource_postgresql_user_mapping.go Outdated Show resolved Hide resolved
postgresql/resource_postgresql_user_mapping.go Outdated Show resolved Hide resolved
postgresql/resource_postgresql_user_mapping.go Show resolved Hide resolved
@fabiopaiva
Copy link
Contributor Author

@cyrilgdn could you please review it again?

@fabiopaiva fabiopaiva requested a review from cyrilgdn August 16, 2022 07:46
@fabiopaiva
Copy link
Contributor Author

@cyrilgdn, any update?

@fabiopaiva
Copy link
Contributor Author

@cyrilgdn

@fabiopaiva fabiopaiva force-pushed the feature/foreign-server branch from 7b7a3d9 to faf69ca Compare November 16, 2022 14:49
cyrilgdn
cyrilgdn approved these changes Nov 20, 2022
View reviewed changes
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Sorry again, I was off the project for a while (lack of time).

I'll release your work on next version (this week) 👍

@cyrilgdn cyrilgdn merged commit 26ec0cf into cyrilgdn:master Nov 20, 2022
@fabiopaiva fabiopaiva deleted the feature/foreign-server branch November 22, 2022 13:58
@cyrilgdn
Copy link
Owner

v1.18.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasboussekey thomasboussekey thomasboussekey approved these changes

@PascalBourdier PascalBourdier PascalBourdier approved these changes

@cyrilgdn cyrilgdn cyrilgdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for foreign server and user mapping
4 participants
@fabiopaiva @cyrilgdn @PascalBourdier @thomasboussekey