Fix golangci-lint error and run it in GH actions.

.github/workflows/golangci.yml

@@ -0,0 +1,19 @@
+name: Golangci-Lint
+
+on: [pull_request]
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2.3.4
+
+      - name: Setup Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.x
+
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v2.5.2
+        with:
+          version: v1.40

.golangci.yml

@@ -0,0 +1,5 @@
+issues:
+  exclude-rules:
+    - linters:
+        - errcheck
+      text: "Error return value of `d.Set` is not checked"

postgresql/resource_postgresql_default_privileges.go

@@ -264,7 +264,7 @@ func grantRoleDefaultPrivileges(txn *sql.Tx, d *schema.ResourceData) error {
 		pq.QuoteIdentifier(role),
 	)
 
-	if d.Get("with_grant_option").(bool) == true {
+	if d.Get("with_grant_option").(bool) {
 		query = query + " WITH GRANT OPTION"
 	}
 

postgresql/resource_postgresql_grant.go

@@ -384,7 +384,7 @@ func createGrantQuery(d *schema.ResourceData, privileges []string) string {
 		}
 	}
 
-	if d.Get("with_grant_option").(bool) == true {
+	if d.Get("with_grant_option").(bool) {
 		query = query + " WITH GRANT OPTION"
 	}
 
@@ -493,7 +493,7 @@ func checkRoleDBSchemaExists(client *Client, d *schema.ResourceData) (bool, erro
 		if err != nil {
 			return false, err
 		}
-		defer dbTxn.Rollback()
+		defer deferredRollback(dbTxn)
 
 		// Check the schema exists (the SQL connection needs to be on the right database)
 		exists, err = schemaExists(dbTxn, pgSchema)

postgresql/resource_postgresql_role.go

@@ -564,7 +564,9 @@ func readRolePassword(db *DBConnection, d *schema.ResourceData, roleCanLogin boo
 	if statePassword != "" && !strings.HasPrefix(statePassword, "md5") && !strings.HasPrefix(statePassword, "SCRAM-SHA-256") {
 		if strings.HasPrefix(rolePassword, "md5") {
 			hasher := md5.New()
-			hasher.Write([]byte(statePassword + d.Id()))
+			if _, err := hasher.Write([]byte(statePassword + d.Id())); err != nil {
+				return "", err
+			}
 			hashedPassword := "md5" + hex.EncodeToString(hasher.Sum(nil))
 
 			if hashedPassword == rolePassword {

postgresql/resource_postgresql_schema.go

@@ -568,16 +568,6 @@ func schemaChangedPolicies(old, new []interface{}) (dropped, added, update, unch
 	return droppedRoles, addedRoles, updatedRoles, unchangedRoles
 }
 
-func schemaPolicyToHCL(s *acl.Schema) map[string]interface{} {
-	return map[string]interface{}{
-		schemaPolicyRoleAttr:            s.Role,
-		schemaPolicyCreateAttr:          s.GetPrivilege(acl.Create),
-		schemaPolicyCreateWithGrantAttr: s.GetGrantOption(acl.Create),
-		schemaPolicyUsageAttr:           s.GetPrivilege(acl.Usage),
-		schemaPolicyUsageWithGrantAttr:  s.GetGrantOption(acl.Usage),
-	}
-}
-
 func schemaPolicyToACL(policyMap map[string]interface{}) acl.Schema {
 	var rolePolicy acl.Schema
 
@@ -615,11 +605,6 @@ func generateSchemaID(d *schema.ResourceData, databaseName string) string {
 	return SchemaID
 }
 
-func getSchemaNameFromID(ID string) string {
-	splitted := strings.Split(ID, ".")
-	return splitted[0]
-}
-
 func getDBSchemaName(d *schema.ResourceData, databaseName string) (string, string, error) {
 	database := getDatabase(d, databaseName)
 	schemaName := d.Get(schemaNameAttr).(string)

postgresql/utils_test.go

@@ -177,11 +177,10 @@ func createTestTables(t *testing.T, dbSuffix string, tables []string, owner stri
 	// In this case we need to drop table after each test.
 	return func() {
 		db, err := sql.Open("postgres", config.connStr(dbName))
-		defer db.Close()
-
 		if err != nil {
 			t.Fatalf("could not open connection pool for db %s: %v", dbName, err)
 		}
+		defer db.Close()
 
 		if owner != "" && !config.Superuser {
 			if _, err := db.Exec(fmt.Sprintf("GRANT %s TO CURRENT_USER", owner)); err != nil {