Correctly save role with quoted search path #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lovromazgon Thanks for moving it. I'll take a look in the next couple of days and add it to the next minor version. |
|
FYI, this has just been released in v1.9.0. |
michaellzc
referenced
this pull request
in sourcegraph/terraform-provider-postgresql
Oct 13, 2022
feat: create temporary file containing Google credentials
wilsonjackson
referenced
this pull request
in Leafly-com/terraform-provider-postgresql
Jan 6, 2023
Feat add column level management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Moving hashicorp/terraform-provider-postgresql#200 to new repository)
Issue
When defining a search path in a PostgreSQL role which contains a hyphen it is saved as a quoted string in the DB. Once it is retrieved from the database the provider saves the quoted search path in the terraform state. Next time the changes are applied this is detected as a change that will be applied, although it actually is not a change.
Solution
When reading the search path from PostgreSQL we have to trim the quotes.