Harmonize Component test workflow to E2E example workflows #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcC399
force-pushed
the
fix/component-test-workflow
branch
from
10eca12
to
eb780a8
Compare
jaffrepaul
approved these changes
Feb 8, 2023
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestions from issue #770 "Harmonize Component test workflow" regarding the workflow .github/workflows/example-component-test.yml.
example-component-testso that it appears sorted in the left-hand side of GH Action view together with the E2E tests.pushto branches other thanmaster.ubuntu-22.04. This makes it clearer exactly which version is being used and it aligns it with the default version used in all E2E tests.Verification
Manually run workflow and ensure it is successful.
Push to a branch other than
masterand check that the workflow is not triggered.