Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(deps): add node.js 23 (current) to tests #1281

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Node.js 23.0.0 was released on Oct 16, 2024.

This PR adds Node.js 23 to the matrix of tested nodes under .github/workflows/example-node-versions.yml, to the README examples and to the README > Node.js > Support section.

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 added documentation Improvements or additions to documentation type: enhancement New feature or request type: dependencies tests labels Oct 17, 2024
@MikeMcC399 MikeMcC399 self-assigned this Oct 17, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 18, 2024 06:31
@MikeMcC399

This comment was marked as off-topic.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jennifer-shehane jennifer-shehane merged commit 94ba88d into cypress-io:master Oct 21, 2024
75 checks passed
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

Cypress is passing all tests on Node.js v23.0.0 🎉 👍🏻

There are two related open issues to be aware of:

This can cause an ExperimentalWarning to be logged:

(node:1989) ExperimentalWarning: Support for loading ES Module in require() is an experimental feature and might change at any time
(Use node --trace-warnings ... to show where the warning was created)

There is no action for Cypress at this time due to the warnings.

@MikeMcC399 MikeMcC399 deleted the add/node-23 branch October 21, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests type: dependencies type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants