feat: Add 'no-empty-tests' rule #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've forked the project and welcome PRs: #100. |
|
|
AtofStryker
reviewed
Aug 31, 2023
There was a problem hiding this comment.
@davidkaufmann are you still interested in contributing this? I was asked to take a look at a few stale PRs and wanted to see if you were interested as well as willing to sign the CLA?
| Empty tests will always pass. | ||
| In large testsuites tests might have been initialized but not yet written. | ||
| Passing but nevertheless empty tests will suggest functionality has been tested, although it hasn't. | ||
| Having empty tests might seem convenient for reasons, it isn't on execution though. |
There was a problem hiding this comment.
Suggested change
| Having empty tests might seem convenient for reasons, it isn't on execution though. |
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty tests will always pass.
In large testsuites tests might have been initialized but not yet written.
Passing but nevertheless empty tests will suggest functionality has been tested, although it hasn't.
Having empty tests might seem convenient for reasons, it isn't on execution though.
Empty tests should always be deleted or skipped.