Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name to configs (for tooling) #214

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jul 23, 2024

feat: add name to configs (for tooling)

ESLint recommends a name for flat configs.

Tools like https://github.com/eslint/config-inspector can use this to indicate the source of rules.

I did not add it to the older, non-flat config because it will err there.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator

@brettz9

Thank you! This is helpful. I tried it out on the https://github.com/cypress-io/cypress-example-kitchensink repo as follows:


BEFORE

git clone https://github.com/cypress-io/cypress-example-kitchensink
cd cypress-example-kitchensink
npm ci
npx @eslint/config-inspector@latest

image


AFTER

git switch -c test/cy-eslint-pr-214
npm install https://github.com/brettz9/eslint-plugin-cypress#name
npx @eslint/config-inspector@latest

image

Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this enhancement!

@jennifer-shehane jennifer-shehane merged commit e644392 into cypress-io:master Jul 24, 2024
9 checks passed
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants