Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace moment with dayjs in pkg/driver #9110

Closed

Conversation

mrmodise
Copy link
Contributor

@mrmodise mrmodise commented Nov 5, 2020

User facing changelog

Replace momentjs with dayjs in pkg/driver code base

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2020

Thanks for taking the time to open a PR!

@mrmodise mrmodise changed the title chore: replace moment with dayjs in driver code chore: replace moment with dayjs in pkg/driver Nov 5, 2020
@mrmodise mrmodise marked this pull request as draft November 6, 2020 01:07
@mrmodise mrmodise force-pushed the update-moment-to-dayjs-driver branch from d5117c7 to 6965d38 Compare November 6, 2020 02:00
@mrmodise mrmodise marked this pull request as ready for review November 6, 2020 02:17
@mrmodise mrmodise force-pushed the update-moment-to-dayjs-driver branch from 6965d38 to e8a6341 Compare November 6, 2020 02:20
@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Nov 6, 2020
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a pretty large breaking change. Moment is exposed as a utility function directly onto Cypress. See https://on.cypress.io/moment

For now, I would delay accepting a PR to move the driver off of moment until our team has discussed how we want to handle the change to our API.

@mrmodise
Copy link
Contributor Author

mrmodise commented Nov 6, 2020

This would be a pretty large breaking change. Moment is exposed as a utility function directly onto Cypress. See https://on.cypress.io/moment

For now, I would delay accepting a PR to move the driver off of moment until our team has discussed how we want to handle the change to our API.

Cool based on this comment i will close the PR accordingly. Thanks

@mrmodise mrmodise closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Moment.js within the Cypress project.
2 participants