chore: Replace usage of moment in cli / server code

[jennifer-shehane]

• Partially addresses Replace Moment.js within the Cypress project. #8714

User facing changelog

N/A - this is not user facing

Additional Details

We'll be moving forward with removing moment.js from the driver and cli types in the 7.0 breaking change.

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

9268 • 0 • 118 • 3

---

Run details

Project	cypress
Status	Passed
Commit	7354676
Started	Jan 26, 2021 5:50 AM
Ended	Jan 26, 2021 6:02 AM
Duration	12:01 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[chrisbreiding]

I'm guessing the cli types are there because of Cypress.moment in the driver. Maybe we should also replace it in the driver and get rid of Cypress.moment in time for 6.0?

[jennifer-shehane]

Yeah, I am expecting this to be removed likely from the driver, but think this will probably be better slated for 7.0. Maybe we could add a deprecated warning soon though.

[flotwig]

I'm guessing the cli types are there because of Cypress.moment in the driver. Maybe we should also replace it in the driver and get rid of Cypress.moment in time for 6.0?

I'm in favor of this change, users can import moment themselves if they really need it

[panzarino]

Didn't manually test but knowing the two libraries have the same API and tests pass, LGTM

[jennifer-shehane]

The server-e2e-tests-chrome test flakes every single time on a different test to where I cannot get a passing example. Going to merge anyway.