refactor: replace momentjs in desktop #8959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
jennifer-shehane
previously approved these changes
Oct 26, 2020
| cy.get('@firstRunRow').contains('24:47') | ||
| cy.get('.runs-container li').eq(3).contains('45:47') | ||
| cy.get('@firstRunRow').contains('12:24:47') | ||
| cy.get('@fourthRunRow').contains('12:45:47') |
There was a problem hiding this comment.
This is what the full value always was - before the changes in this branch.
| @@ -1,6 +1,31 @@ | |||
| import _ from 'lodash' | |||
| import gravatar from 'gravatar' | |||
| import duration from '../../../server/lib/util/duration' | |||
There was a problem hiding this comment.
yah, it would be nice to sync this back with the server after it's updated to remove moment.js also
jennifer-shehane
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Replaced momentjs dependency in desktop application
Additional details
Used dayjs to replace the few momentjs functions used in the desktop app. Tried date-fns first but dayjs much more closely follows the momentjs api. Also the locale options for date-fns regarding formatting durations differed a bit. Some of the dates were formatted by a function imported from the server package, I left that intact and just created a similar function using dayjs in this package.
Also added an extra test for the
getFormattedTimeFromNowmethod, I started by adding more test cases (e.g. 44 seconds, 45 seconds, ...) but then it just felt like I was testing the dayjs functionality so I only kept 1 case.How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?