fix: (driver) - Fix for introduced regression in cy.route #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
1 task
przemuh
changed the title
There was a problem hiding this comment.
I manually verified that this is working now in cases of a non-existent file and a larger file as expected. Would maybe be nice to have a test for the larger files, but I know this has been challenging before because we don't want to check in large files into the repo.
May be tangentially related to this issue, but not really a concern of this PR. Just wanted to mention: #8164
|
It should be possible to dynamically generate a large fixture file in the test so it doesn't need to be committed to the repo. I think we have an example of something like that, but I haven't been able to find it yet. |
…fixture inside the route command
|
Good, tried it, shows an error
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for introduced regression from #7983 in cy.route fixture inside the route command
First of all I'm sorry for introduced regression. I didn't mean to and I hope you will forgive me :) I've decided to revert some of my changes related to load fixture in
cy.route. The only thing I left is a improved error message in case when fixture doesn't exist.cy.routewithfxandfixtureshortcut take longer to load, sometimes timeout. #8181User facing changelog
Revert the code that tries to load a fixture inside a cy.route command.
Additional details
We don't need to try load a fixture inside a cy.route. Error message has been improved, but it will show up only when user waits for a stubbed route or returns a rejected promise from custom command.
In every other case, test will be not marked as failed (even when fixture has not been found).
How has the user experience changed?
Previous behaviour of
cy.routehas been restored. Error message in case of missing fixture has been improved.PR Tasks