-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decaff driver part 0 #7004
Decaff driver part 0 #7004
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could probably nitpick a few tiny things, but overall this is great. Functionally looks solid. Can't wait to get this in. Thanks @sainthkh 💯
return type === 'check' | ||
? $el.prop('checked') | ||
: !$el.prop('checked') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation ends up being the same (seeing all the calls) in this case although not a one to one comparison of previous code.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Preparation for breaking down #5762. This time, I'll decaff the entire driver package. As it's a big project, I'll break it down to a few steps to make it easier to review.
NEVER SQUASH THIS PR