-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert command actions tests to Javascript #6591
Convert command actions tests to Javascript #6591
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
@clarmso Couple of lint warnings
|
…/clarmso/cypress into issue-2690-command-actions-tests
@jennifer-shehane Oh darn. I didn't catch the lint error yesterday. (Scratching head...) It should be fixed now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clarmso Continuously merging in the develop branch and making more commits is going to mess up the final commit. We don't squash commits for decaffeinate, so need this PR left to the maximum of the decaffeinate commits + 1 cleanup commit. Is there any way you can clean up commits here?
…/clarmso/cypress into issue-2690-command-actions-tests
My git squash/rebase is a fail again. :( Let me include my change in a new branch. (It's quicker...) EDIT: See #6647 |
This PR consists of the command actions tests from the driver package converted to Javascript from Coffeescript. The conversion has been done via the following command:
cypress/.vscode/tasks.json
Line 15 in 844606b
I've converted the files in as few commits as possible. (bulk-decaffeinate creates commits for stages of the conversion.) Please do not squash this commit. :)
A part of #2690
User facing changelog
No user facing changelog specific to these tests should be needed.
Additional details
This PR is a part of continuous improvement in maintaining the codebase. We hope the codebase will be in Typescript. :) Javascript is an intermediate step.
I've reviewed the results of the bulk-decaffeinate command. I've ensured the following:
How has the user experience changed?
No noticeable changes should be detected by the developers and the users. The new version of the tests should work the same as the old Coffeescript ones.
PR Tasks