Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Circle CI for Windows builds, remove AppVeyor #5550

Closed
wants to merge 136 commits into from

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 31, 2019

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 31, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Oct 31, 2019



Test summary

6946 0 97 0


Run details

Project cypress
Status Passed
Commit 48953c9
Started Feb 26, 2020 10:39 PM
Ended Feb 26, 2020 10:45 PM
Duration 05:47 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig
Copy link
Contributor Author

flotwig commented Oct 31, 2019

Can't figure out how to set a default shell for the windows executor, it seems to not work as documented on their site. Waiting for a reply from support before proceeding.

This reverts commit 5134ea4.
@flotwig flotwig marked this pull request as draft April 20, 2020 15:13
@flotwig flotwig changed the title [WIP] Use Circle CI for Windows builds, remove AppVeyor Use Circle CI for Windows builds, remove AppVeyor Apr 20, 2020
@jennifer-shehane
Copy link
Member

Closing this due to inactivity. Please reopen if there is work to be done addressing this again.

@flotwig flotwig deleted the circleci-windows branch January 24, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchensink hangs starting a test on CircleCI Windows
4 participants