-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes flaky test in rerun_spec.coffee. #5546
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this. Maybe not the root of the flake, but will stop this test from being flaky.
I'm sorry, I squashed it. I did wrong 😭 Will not do again. |
User facing changelog
Fixes a flaky test.
Additional details
Why was this change necessary?
This makes CI fail without reason.
What is affected by this change?
Something went wrong in compiling coffeescript to javascript. So, it is decaffeinated.
Any implementation details to explain?
n/a
How has the user experience changed?
n/a
PR Tasks
Has a PR for user-facing changes been opened incypress-documentation
?Have API changes been updated in thetype definitions
?Have new configuration options been added to thecypress.schema.json
?