Change dep of mocha-teamcity-reporter to be official release instead of cypress branch #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of cypress branch
brian-mann
previously requested changes
Jul 3, 2019
jennifer-shehane
changed the title
jennifer-shehane
changed the title
chrisbreiding
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’ve been including a fork of mocha-teamcity-reporter, see @cypress/mocha-teamcity-reporter, as a dependency and making this available as a builtin reporter for our users. But upon looking at our fork, it looks like it only includes 1 change from 4 years ago which was added to support nwjs (which we no longer use).
This will bump the mocha-teamcity-reporter from our forked version (which was pre-version 0.0.4) to version 3.0.0, so I wouldn’t be surprised if some things break.
I’ll progressively downgrade the official mocha-teamcity-reporter and then re-upgrade if that is the case.
Hoping to address #4637
Close #4654