Fix run_plugins_spec test leaking into other tests, other flake in request_spec
#4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
changed the title
run_plugins_spec test leaking into other testsrun_plugins_spec test leaking into other tests, other flake in request_spec
flotwig
changed the title
run_plugins_spec test leaking into other tests, other flake in request_specrun_plugins_spec test leaking into other tests, other flake in request_spec
brian-mann
approved these changes
Jul 2, 2019
brian-mann
reviewed
Jul 2, 2019
| @@ -72,7 +72,7 @@ describe "lib/plugins/child/run_plugins", -> | |||
| @ipc.on.withArgs("load").yields({}) | |||
| runPlugins(@ipc, "plugins-file") | |||
|
|
|||
| @ipc.send = (event, errorType, pluginsFile, stack) -> | |||
| @ipc.send = _.once (event, errorType, pluginsFile, stack) -> | |||
There was a problem hiding this comment.
I'm approving but why can't we use sinon to handle the mocking behavior since it's automatically torn down at the end of the test?
If that doesn't work - then we have something else still running async in the background causing the leak into another test - and likely the code needs to be refactored to properly handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4481
Also increases the timeout on the 4x retry test for ECONNRESET, I could never get it to flake locally, only in CI, assuming it's just random slowdown. Bumping timeout from 100 to 250ms should fix this.