Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when a percent-encoded URL is passed to cy.route #4561

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Warn when a percent-encoded URL is passed to cy.route #4561

merged 4 commits into from
Jul 9, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 25, 2019

Fixes #2372

@flotwig flotwig changed the title [WIP] Warn when a percent-encoded URL is passed to cy.route Warn when a percent-encoded URL is passed to cy.route Jun 25, 2019
@flotwig flotwig requested a review from a team June 25, 2019 17:11
@jennifer-shehane
Copy link
Member

Just kind of seems like if we can detect that it's encoded then why not just decode it for them?

@flotwig
Copy link
Contributor Author

flotwig commented Jun 26, 2019

@jennifer-shehane What if the user is literally trying to do cy.route('%25'), to match URLs like "http://example.com/%25" (encoded: "http://example.com/%2525")? There would be no way to express that if we decoded it for them.

@flotwig flotwig requested a review from jennifer-shehane July 2, 2019 13:43
@jennifer-shehane jennifer-shehane requested a review from a team July 3, 2019 05:09
@flotwig flotwig merged commit bfec784 into develop Jul 9, 2019
@cypress-bot cypress-bot bot mentioned this pull request Jul 9, 2019
Closed
@flotwig flotwig deleted the issue-2372 branch January 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cy.route() doesn't recognize % sign
2 participants
@flotwig @jennifer-shehane