Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use percentiles to make proxy performance test not flaky #4507

Merged
merged 4 commits into from
Jun 20, 2019
Merged

Use percentiles to make proxy performance test not flaky #4507

merged 4 commits into from
Jun 20, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 19, 2019

No description provided.

@brian-mann
Copy link
Member

Is this still WIP?

@flotwig
Copy link
Contributor Author

flotwig commented Jun 20, 2019 •
edited
Loading

@brian-mann Yeah, trying to figure out why it times out failing to connect to CDP every once in a while. Might just add a this.retries = 3 and be done with it.

@flotwig flotwig changed the title [WIP] Use percentiles to make proxy performance test not flaky Use percentiles to make proxy performance test not flaky Jun 20, 2019
@flotwig
Copy link
Contributor Author

flotwig commented Jun 20, 2019

@brian-mann Good to go now 👍

@flotwig flotwig requested a review from mapsandapps June 20, 2019 15:44
@brian-mann brian-mann merged commit 989f516 into develop Jun 20, 2019
@flotwig flotwig removed the request for review from mapsandapps June 20, 2019 20:22
@flotwig flotwig deleted the fix-proxy-perf-tests branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flotwig @brian-mann