[#4461] Change typescript declaration for .writeFile() #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrKovalenko
commented
Jun 14, 2019
| @@ -2318,6 +2318,12 @@ declare namespace Cypress { | |||
| cancelable: boolean | |||
| } | |||
|
|
|||
| /** Options to change the default behavior of .writeFile */ | |||
| interface WriteFileOptions extends Loggable { | |||
| flag: string | |||
There was a problem hiding this comment.
flag is only string even in native node's fs declarations
bahmutov
reviewed
Jun 14, 2019
| @@ -1776,13 +1776,13 @@ declare namespace Cypress { | |||
| }) | |||
| ``` | |||
| */ | |||
| writeFile<C extends FileContents>(filePath: string, contents: C, options?: Partial<Loggable>): Chainable<C> | |||
| writeFile<C extends FileContents>(filePath: string, contents: C, encoding: Encodings): Chainable<C> | |||
| /** | |||
| * Write to a file with the specified encoding and contents. | |||
| * | |||
| * @see https://on.cypress.io/writefile | |||
There was a problem hiding this comment.
can we add an example here?
bahmutov
suggested changes
Jun 14, 2019
bahmutov
previously approved these changes
Jun 14, 2019
|
@dmtrKovalenko how is your text editor set up - leaves trailing whitespace |
|
@bahmutov I am using prettier + eslint. Tslint is deprecated https://medium.com/palantir/tslint-in-2019-1a144c2317a9 |
|
@dmtrKovalenko we use |
|
Yeah, I know but it is deprecated way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4461
Changing typescript definition signature for
.writeFilemethod according to the docs.