-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that test titles are strings before sanitizing them for screenshot names #4317
Conversation
jennifer-shehane
commented
May 28, 2019
- Close 'Cannot read property \'replace\' of null' from sanitize-filename err being thrown #4310
- Write tests for many non-string values to ensure screenshot is taken.
@jennifer-shehane why are we allowing non-string test titles anyways? If we error earlier then we wouldn't need to add this logic or ever account for non-string test names again. |
@bkucera They already work. They work fine when running tests in Cypress and other frameworks, it's just when we try to translate the title to a screenshot filename that it borks. |
@jennifer-shehane how does it look in the dashboard though? reporters? I don't think we handle non-strings anywhere else really. If there's a discussion about this (allowing non-string test titles) somewhere i'd like to read it |
We're converting them all to strings, so it wouldn't display any other way in the Dashboard. I have no idea how reporters handle it. |
@bkucera regarding test titles which are purely
|