Make extension have a static ID so it can be whitelisted #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm can we embed an Easter egg like “cypressio” inside the id
…Sent from my iPhone
On Mar 8, 2019, at 16:55, Zach Bloomquist ***@***.***> wrote:
Fixes #1239
This PR makes the extension have a static ID so it can be whitelisted.
The extension ID for Cypress is: caljajdfkjjjdehjdoimjkkakekklcck
You can view, comment on, or merge this pull request online at:
#3674
Commit Summary
extension: add static key to manifest.json
File Changes
M packages/extension/app/manifest.json (1)
M packages/extension/test/unit/extension_spec.coffee (12)
Patch Links:
https://github.com/cypress-io/cypress/pull/3674.patch
https://github.com/cypress-io/cypress/pull/3674.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@bahmutov it's funny you asked... I wrote a shell script to bruteforce extension IDs to do just that, then I realized you can only use characters from A to P (shifted hexadecimal): https://gist.github.com/flotwig/37121c884d2f19712935eb1bc9a55efe Too bad. This ID does begin with "c" though. I'm open to other ideas that only use characters between A and P. |
|
I knew you were one step ahead. Yeah, but still people manage to hide eggs in hex code
…Sent from my iPhone
On Mar 8, 2019, at 19:18, Zach Bloomquist ***@***.***> wrote:
@bahmutov it's funny you asked... I wrote a shell script to bruteforce extension IDs to do just that, then I realized you can only use characters from A to P (shifted hexadecimal):
https://gist.github.com/flotwig/37121c884d2f19712935eb1bc9a55efe
Too bad. It does begin with "c" though. I'm open to other ideas that only use characters between A and P.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Just curious why this needs to happen? since we build the extension locally and pass it in via command line arguments - in what scenario would a user need this to be whitelisted? |
|
@brian-mann There's a Chrome policy that sets a whitelist of permitted extension IDs, apparently it has been causing problems with loading the extension: #1239 (comment) |
|
Can we instead accept this via a command line flag? I don’t think we want to embed the ID directly in the manifest for reasons. Then people could generate their own extension id and we’d load the extension with this in the manifest. |
|
@brian-mann This is also helpful in situations where the user's company blocks extensions by id as detailed here: #2494 |
flotwig
changed the title
brian-mann
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Approving. @jennifer-shehane we need to add this to the docs.
I think we should also accept the extension ID via CLI flags but that can be a separate PR.
This was referenced Mar 15, 2019
|
🎶super caljajdfkjjjdehjdoimjkkakekklcck expialidocious 🎶 |
|
Hi @brian-mann could you elaborate more on the fact it's build locally? Is the extension built on users machine during the install process (and Chrome is provided with a location to the unpacked extension- or is there a CRX file involved)? My company does not allow whitelisting by ID and instead we must package an approved CRX file which can then be installed to users machines. |
|
@jaredrada There is no Is your organization using the |
|
Thanks for the quick reply. Will have to look into that route or alternatively see if you'll add support for running in Chrome w/o using the extension as mentioned in #2494 (comment) as it appears most of the engineering was done for headless Chrome.
|
|
@flotwig @jaredrada / @brian-mann / @jennifer-shehane So, our company blocks all extension and selectively whitelists fe extension. I have the latest Cypress installed and IT has whitelisted the extension ID for Cypress is: caljajdfkjjjdehjdoimjkkakekklcck. When using WINDOWS "admin" account the static extension id is available and tests get executed in chrome browser. However when using a windows local-user (non admin) the extension is not available ('cy' icon is not present in the browser and doesn't show up under extensions)and standard error page is displayed. The company policy prevents from users having an elevated or admin-like account so the tester's can't really run the tests. Any suggestions / workarounds? I've already tried deleting the everything under "cy" folder from "View App Data" and restarted Cypress but that has not helped. Here are the logs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3673
Fixes #1239
This PR makes the extension have a static ID so it can be whitelisted.
The extension ID for Cypress is:
caljajdfkjjjdehjdoimjkkakekklcck