Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 3, 2025

  • Closes

Additional details

Converts @packages/icons to use vitest and removes the ts-node entrypoint making ESM possible

Steps to test

How has the user experience changed?

PR Tasks


Note

Convert @packages/icons to a compiled package with CJS/ESM builds, replace Mocha/Chai tests with Vitest, and update CI/docs accordingly.

  • @packages/icons:
    • Build: Replace ts-node with tsx; add build:cjs/build:esm via tsc with new tsconfig.cjs.json/tsconfig.esm.json and shared tsconfig.base.json; set types and keep index.js/index.d.ts entrypoints; update .gitignore/.eslintignore.
    • Source: Adjust dist path resolution in index.ts to __dirname/dist.
    • Testing: Migrate from Mocha/Chai to Vitest (vitest.config.ts); replace test/icons_spec.ts with test/icons.spec.ts.
    • Deps/Scripts: Add vitest and tsx; update scripts (build, build-assets, test-unit, check-ts).
  • CI: Decrease sanitize-verify-and-store-mocha-results expectedResultCount from 10 to 9 in unit tests.
  • Docs: Update guides/esm-migration.md checklist (mark packages/icons complete; adjust https-proxy entries).
  • Lockfile: Reflect new deps (vitest, tsx) and cleanup mocha range.

Written by Cursor Bugbot for commit 27aa98a. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Oct 3, 2025
@AtofStryker AtofStryker changed the title Chore/icons vitest chore: convert icons to a compiled package and convert tests to vitest Oct 3, 2025
Copy link

cypress bot commented Oct 3, 2025

cypress    Run #66160

Run Properties:  status check passed Passed #66160  •  git commit 27aa98a6c4: chore: make icons builds from source and remove ts-node entry point to make ESM ...
Project cypress
Branch Review chore/icons_vitest
Run status status check passed Passed #66160
Run duration 22m 50s
Commit git commit 27aa98a6c4: chore: make icons builds from source and remove ts-node entry point to make ESM ...
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 13
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26661
View all changes introduced in this branch ↗︎
UI Coverage  45.11%
  Untested elements 186  
  Tested elements 157  
Accessibility  97.76%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 110  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant