chore (draft): package @packages/network as an independent bundle
#32633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/network-bundle
|
| Run status |
|
| Run duration | 19m 51s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
9
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26661
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.11%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
157
|
Accessibility
97.76%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
110
|
AtofStryker
force-pushed
the
chore/network-bundle
branch
from
21c3259 to
2b03c2c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/network-bundle
branch
2 times, most recently
from
a6ac039 to
eab0745
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/network-bundle
branch
from
4ce54ef to
1c01f92
Compare
… network-tools is expected to be used in simple environments, where network is intended to be used in the node context. additionally, makes these packages bundable and removes the ts-node entrypoint to make ESM possible.
AtofStryker
force-pushed
the
chore/network-bundle
branch
from
1c01f92 to
187cfd7
Compare
AtofStryker
force-pushed
the
chore/network-bundle
branch
from
187cfd7 to
267df5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Introduces @packages/network-tools for browser/shared networking utilities and refactors imports; updates @packages/network to CJS/ESM builds with async APIs, and adjusts tests/CI accordingly.
@packages/network-toolscors,uri,document-domain-injection, and related types for browser/shared use.@packages/networkwith@packages/network-toolsindriver,proxy,server,config, and tests (e.g., origin/cors/uri helpers, DocumentDomainInjection).origin,getSuperDomain*,url*Match,removeDefaultPort,policyFromConfig).CombinedAgent.connect.getAddress, CA/client cert handling); add typings and minor fixes.@packages/network(-tools)built in binary check job.packages/networkandpackages/network-toolsas completed.Written by Cursor Bugbot for commit 267df5b. This will update automatically on new commits. Configure here.