Skip to content

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Sep 19, 2025

Additional details

Performance Bottlenecks:

  1. Excessive getComputedStyle() calls: Each CSS property access triggers a new getComputedStyle() call
  2. Redundant DOM traversal: elIsHiddenByAncestors recursively walks up the DOM tree, calling expensive functions at each level
  3. Multiple CSS property queries: Functions like elHasOverflowHidden make 3 separate CSS calls
  4. Transform detection overhead: extractTransformInfoFromElements recursively extracts transform info from all ancestors
  5. Repeated bounding rect calculations: getBoundingClientRect() is called multiple times for the same element

Steps to test

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Sep 19, 2025
Copy link

cypress bot commented Sep 19, 2025

cypress    Run #65686

Run Properties:  status check canceled Cancelled #65686  •  git commit 262cdf6640: fix: let's try it out
Project cypress
Branch Review visibility-optimizations
Run status status check canceled Cancelled #65686
Run duration 43m 20s
Commit git commit 262cdf6640: fix: let's try it out
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 15
Tests that were flaky  Flaky 11
Tests that did not run due to a developer annotating a test with .skip  Pending 1015
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 19118
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  44.73%
  Untested elements 189  
  Tested elements 157  
Accessibility  97.71%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 110  

Tests for review

Failed  commands/actions/selectFile.cy.ts • 2 failed tests • 5x-driver-electron

View Output

Test Artifacts
... > can scroll to input Test Replay
... > can specify scrollBehavior in options Test Replay
Failed  commands/command_option_immutability.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  commands/querying/within.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  e2e/origin/commands/log.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  e2e/origin/cookie_misc.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts

The first 5 failed specs are shown, see all 673 specs in Cypress Cloud.

Flakiness  commands/actions/click.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > scrolls a container past a fixed position element when being covered Test Replay
Flakiness  commands/actions/trigger.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > scrolls a container past a fixed position element when being covered Test Replay
Flakiness  commands/actions/selectFile.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > can scroll to label Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant