chore: migrate browser install to use circle orb #30943
Open
+122
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
chore/browser_spike
branch
3 times, most recently
from
e492bdb to
8ebf20f
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/browser_spike
|
| Run status |
|
| Run duration | 08m 22s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
19
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
20%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
1
|
Accessibility
89.8%
|
|
|---|---|
|
Failed rules
|
0 critical
2 serious
0 moderate
0 minor
|
|
Failed elements
|
11
|
AtofStryker
force-pushed
the
chore/browser_spike
branch
22 times, most recently
from
a8ed5fa to
0bd33ab
Compare
AtofStryker
force-pushed
the
chore/browser_spike
branch
2 times, most recently
from
6698e2b to
91b23d9
Compare
AtofStryker
changed the title
…ad of sourcing them from the internal cypress docker images.
AtofStryker
force-pushed
the
chore/browser_spike
branch
from
91b23d9 to
46083b6
Compare
AtofStryker
requested review from
mschile and
cacieprins
and removed request for
mschile
mschile
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR switches from the internal browsers docker image, which installs a specific chrome and firefox browser version, to use the base internal image with the circle ci browser tools orb. This allows us to change and test browser versions without having to publish a docker image every single time
Steps to test
all of this is CI related so testing needs to be done in CI
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?