Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visibility issue when parent element is clipping #30934

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jan 23, 2025

Additional details

  • Fixed visibility issue where an element would return visible when its offset parent was within the clipping element.
  • Fixed issue where the visibility of option elements was not calculated correctly if the an ancestor had an overflow that clipped. The option elements were partially handled in isStrictlyHidden but were not being accounted for in isHiddenByAncestors.
  • Fixed visibility issue where we were not accounting for the scenario where either overflow-x or overflow-y was visible and the other one was clipping.

Steps to test

See new tests

How has the user experience changed?

Before:
Screenshot 2025-01-23 at 2 31 29 PM

After:
Screenshot 2025-01-23 at 2 29 39 PM

Before:
Screenshot 2025-01-23 at 2 45 54 PM

After:
Screenshot 2025-01-23 at 2 44 53 PM

Before:
Screenshot 2025-01-24 at 1 11 19 PM

After:
Screenshot 2025-01-24 at 1 10 34 PM

PR Tasks

Copy link

cypress bot commented Jan 23, 2025

cypress    Run #60051

Run Properties:  status check passed Passed #60051  •  git commit 2a5a57cd66: update changelog
Project cypress
Branch Review mschile/issue-30922
Run status status check passed Passed #60051
Run duration 16m 22s
Commit git commit 2a5a57cd66: update changelog
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 762
View all changes introduced in this branch ↗︎
UI Coverage  64.37%
  Untested elements 29  
  Tested elements 56  
Accessibility  96.19%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 198  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14.0.0: Element being incorrectly seen as visible when it is not visible
1 participant