misc: pass the related command log to the createSnapshot function #30244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/protocol/pass_log_to_snapshot
|
| Run status |
|
| Run duration | 24m 17s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29395
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.04%
|
|
|---|---|
|
Untested elements
|
200
|
|
Tested elements
|
168
|
Accessibility
91.29%
|
|
|---|---|
|
Failed rules
|
5 critical
10 serious
2 moderate
2 minor
|
|
Failed elements
|
950
|
| // if the protocol has been enabled, our snapshot is just the name, timestamp, and highlighted elements, | ||
| // also make sure numTestsKeptInMemory is 0, otherwise we will want the full snapshot | ||
| // (the driver test's set numTestsKeptInMemory to 1 in run mode to verify the snapshots) | ||
| if (Cypress.config('protocolEnabled') && Cypress.config('numTestsKeptInMemory') === 0) { |
There was a problem hiding this comment.
Nice that we're cleaning this up.
ryanthemanuel
approved these changes
Sep 16, 2024
AtofStryker
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The related command log is now being passed to the
createSnapshotfunction so it can be used within the Protocol to determine if a canvas snapshot needs to be taken.Also removed to the dead protocol code in
createSnapshot.Steps to test
Updated the log test to verify the related log is passed to
createSnapshot.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?