chore: update tests to skip the welcome screen on launchpad tests. #30240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-welcome-screen-for-testing
|
| Run status |
|
| Run duration | 18m 11s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
73
|
Skipped
|
0
|
Passing
|
5592
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
AtofStryker
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I was looking at UI Coverage to find redundant tests and I noticed this
[data-cy="major-version-welcome-footer"]element being interacted with 184 times and I thought, hmm...I know we are not wanting to test this button this many times, but it is the starting point of our flow through the App. But the display of this welcome screen is actually conditional.We should really write tests so the default is to NOT have the welcome screen show and instead have the welcome screen show on the few times we want to test it. I updated the e2e support code to do just that.
It doesn't look like this greatly reduces CI resources (for some specs they ran faster), but this will reduce complexity and reduce instances around flake of this page in our tests.
UI Coverage after:
Steps to test
Tests should pass. Also a review of touched tests would be nice because it's possible false positive could be introduced if the behavior tested isn't the same with the setup introduced.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?