Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch new tab creation for firefox 124 and up to fix issue where… #29179

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

AtofStryker
Copy link
Contributor

… cypress was not executing beyond the first spec in cypress run (specific to firefox).

Additional details

This PR addresses an issue with Firefox versions 124 and up where the browsers.tabs extension API behavior changed.
Previously, in versions of Firefox 123 and below, removing all tabs in the browser would result in a new tab being created. Now, in Firefox versions 124 (and beta 125 as well), this behavior no longer happens. Instead, the browser closes, but the process is still running. Cypress cannot find a tab to connect to, and therefor browser connection times out when running the second spec in run mode with npx cypress run -b firefox.

To fix this, this PR creates an about:blank tab (but does not active it) before all the other tabs are removed. This tab is the only remaining tab, which is fairly consistent with the behavior we saw previously in Firefox 123 and lower.

Steps to test

How has the user experience changed?

PR Tasks

… cypress was not executing beyond the first spec in cypress run (specific to firefox).
cli/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@AtofStryker AtofStryker requested a review from cacieprins March 21, 2024 14:10
Copy link

cypress bot commented Mar 21, 2024

1 failed and 9 flaky tests on run #54593 ↗︎

1 29117 1332 0 Flakiness 9

Details:

opt for global window instead of no undef for window reference
Project: cypress Commit: 6f315a2ee2
Status: Failed Duration: 19:56 💡
Started: Mar 21, 2024 5:17 PM Ended: Mar 21, 2024 5:37 PM
Failed  cypress/e2e/e2e/testConfigOverrides.cy.js • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
testConfigOverrides baseUrl @slow > visit 1
    </td>
  </tr></table>
Flakiness  project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output

Test Artifacts
... > shows the configuration setup page when selecting e2e tests Test Replay Screenshots
... > can skip setup CT testing for an E2E project Test Replay Screenshots
Flakiness  config-warning.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
experimentalStudio > is a valid config for e2e testing Test Replay Screenshots
Flakiness  open-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
Launchpad: Open Mode > when there is a list of projects > goes to an active project if one is added Test Replay Screenshots
Flakiness  runner/sessions.ui.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
runner/cypress sessions.ui.spec > recreates session and fails validation Test Replay Screenshots
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > intercept aliases > returns the xhr Test Replay

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #29179 ↗︎

packages/extension/app/v2/background.js Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane merged commit 9c27c37 into develop Mar 21, 2024
74 of 81 checks passed
@jennifer-shehane jennifer-shehane deleted the fix_firefox_124 branch March 21, 2024 17:37
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 21, 2024

Released in 13.7.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only first test runs with Firefox 124.0
5 participants