test: Add commands to wait for config page to load before continue with test - address flaky test #28953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #54061 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #28953 ↗︎
mschile
approved these changes
Feb 19, 2024
mschile
changed the title
AtofStryker
approved these changes
Feb 22, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I saw this launchpad test recently show up as a flaky test: Test Replay.
A passing Test Replay
It looks like we've clicked into a project, then clicked into the breadcrumbs to click into another project. Just as we're trying to click into the other project, the configuration file from the previous project seems jerk us back out with a configuration file error. This is my theory anyway.
I've added some assertions to wait for the configuration page to finish loading before clicking back to projects. Is this an actual bug? Maybe....if we're not stopping loading of the previous project config file when we click into the main projects. I haven't seen this reported before though and it's likely fairly uncommon. So this attempts to just fix our own tests.
Steps to test
Run the global-mode-cy.ts test on the launchpad tests
How has the user experience changed?
N/A