Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change how tsconfig is aliased in webpack-batteries-included-preprocessor #27706

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

chrisbreiding
Copy link
Contributor

Additional details

Addresses this snyk vulnerability. It's not an actual vulnerability in this repo because we aren't using the actual tsconfig-package package, but aliasing the tsconfig package as tsconfig-package to get around a path resolution issue with Node.

My solution is to use a name less likely to end up as a real package name: tsconfig-aliased-for-wbip (wbip === webpack-batteries-included-preprocessor).

Steps to test

Should see a passing snyk check.

PR Tasks

@chrisbreiding chrisbreiding self-assigned this Aug 30, 2023
@cypress
Copy link

cypress bot commented Aug 30, 2023

1 failed and 22 flaky tests on run #50714 ↗︎

1 28099 1355 0 Flakiness 22

Details:

Merge branch 'develop' into fix-erroneous-tsconfig-quote-vulnerability-unquote
Project: cypress Commit: 4db3cb0926
Status: Failed Duration: 20:01 💡
Started: Aug 31, 2023 2:09 PM Ended: Aug 31, 2023 2:29 PM
Failed  cypress/e2e/cypress-in-cypress.cy.ts • 1 failed test • app-e2e

View Output Video

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Output Screenshots
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App: Runs > no internet connection > shows correct message on connect project modal Test Replay Output Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

Review all test suite changes for PR #27706 ↗︎

@chrisbreiding chrisbreiding changed the title chore: change how tsconfig is aliased in webpack-batteries-included-preprocessor fix: change how tsconfig is aliased in webpack-batteries-included-preprocessor Aug 31, 2023
@nagash77 nagash77 merged commit 6081751 into develop Aug 31, 2023
17 of 64 checks passed
@nagash77 nagash77 deleted the fix-erroneous-tsconfig-quote-vulnerability-unquote branch August 31, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants