-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-dev-server): add typeRoots to generated tsconfig for angular #27117
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b1e9722
feat(webpack-dev-server): generate a local tsconfig file
jordanpowell88 c8ab14f
chore: remove comments
jordanpowell88 5e8e19d
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 cf58585
chore: use relative paths
jordanpowell88 49923d3
Merge branch 'jordanpowell88/angular-tsconfig' of https://github.com/…
jordanpowell88 1f896b1
test(webpack-dev-server): update tsconfig tests
jordanpowell88 c8b808a
test(webpack-dev-server): update tsconfig tests
jordanpowell88 0d9a97a
test(webpack-dev-server): update tsconfig tests
jordanpowell88 52954af
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 a2d3987
Merge branch 'jordanpowell88/angular-tsconfig' of https://github.com/…
jordanpowell88 d3b8dd2
test(webpack-dev-server): upt outDir path
jordanpowell88 e8ab248
chore: build binary
jordanpowell88 fe130b7
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 3b2bb4b
Update npm/webpack-dev-server/src/helpers/angularHandler.ts
jordanpowell88 b7c85c6
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 491a0d2
fix(webpack-dev-server): use tmp but add typeRoots
jordanpowell88 20112de
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 9810e56
chore: update workflow to build binary
jordanpowell88 15aca64
Merge branch 'jordanpowell88/angular-tsconfig' of https://github.com/…
jordanpowell88 202ccc2
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 eb9a225
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 c991d53
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 aec1dab
Merge branch 'develop' into jordanpowell88/angular-tsconfig
jordanpowell88 67b86c8
remove redundant node_modules/types
jordanpowell88 1434534
remove node_modules/types from assertions
jordanpowell88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this was just to get pretty formatting? Still needed since this is dumping to a temp dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, but makes it "pretty"er 🤣