Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: debug page tooltip distance and artifact border #25727

Merged
merged 6 commits into from
Feb 8, 2023
Merged

misc: debug page tooltip distance and artifact border #25727

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
418e49c
misc: debug page tooltip distance and artifact border
ZachJW34 Feb 6, 2023
d1dbcb9
add changelog entry
ZachJW34 Feb 6, 2023
8dc0661
Merge remote-tracking branch 'origin/develop' into zachw/debug-tooltips
ZachJW34 Feb 6, 2023
74744b4
fix CT test
ZachJW34 Feb 7, 2023
26422cb
Merge branch 'develop' into zachw/debug-tooltips
ZachJW34 Feb 7, 2023
2fa7749
Merge branch 'develop' into zachw/debug-tooltips
ZachJW34 Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ _Released 02/14/2023 (PENDING)_

- Improved the layout of the Debug Page on smaller viewports when there is a pending run. Addresses [#25664](https://github.com/cypress-io/cypress/issues/25664).
- Icons in Debug page will no longer shrink at small viewports. Addresses [#25665](https://github.com/cypress-io/cypress/issues/25665).
- Increased the spacing between elements and their associated tooltip and added borders around artifact links on the Debug Page. Addresses [#25666](https://github.com/cypress-io/cypress/issues/25666).

**Dependency Updates:**

Expand Down
4 changes: 3 additions & 1 deletion packages/app/src/debug/DebugArtifactLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
<Tooltip
placement="bottom"
:data-cy="`artifact-for-${icon}`"
:distance="8"
>
<ExternalLink
class="flex h-full w-full items-center justify-center"
class="flex h-24px w-24px justify-center items-center hocus:rounded-md group hocus:border-1px hocus:border-indigo-500"
:data-cy="`${icon}-button`"
:href="props.url || '#'"
:use-default-hocus="true"
Expand All @@ -16,6 +17,7 @@
fill-color="gray-100"
hocus-stroke-color="indigo-500"
hocus-fill-color="indigo-100"
interactive-colors-on-group
/>
</ExternalLink>
<template #popper>
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/debug/DebugFailedTest.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<div
v-if="!props.expandable"
data-cy="debug-artifacts"
class="flex flex-grow space-x-4.5 opacity-0 px-18px justify-end test-row-artifacts"
class="flex flex-grow opacity-0 px-18px gap-16px justify-end test-row-artifacts"
>
<div
v-for="result, i in failedTestData.debugArtifacts"
Expand Down
5 changes: 3 additions & 2 deletions packages/app/src/debug/DebugSpec.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@
color="dark"
:is-interactive="!!(runAllFailuresState.cta)"
:disabled="!runAllFailuresState.disabled"
:distance="8"
>
<Button
data-cy="run-failures"
Expand Down Expand Up @@ -186,9 +187,9 @@
<div
v-for="thumbprint in Object.keys(specData.failedTests)"
:key="`test-${thumbprint}`"
:data-cy="`test-group`"
data-cy="test-group"
class="flex flex-col flex-start border-b-gray-100 border-b-1px w-full pr-16px pl-16px justify-center"
:class="Object.keys(specData.groups).length > 1 ? 'pb-16px': 'hover:bg-gray-50'"
:class="Object.keys(specData.groups).length > 1 ? 'pb-16px': 'hover:bg-gray-50 focus-within:bg-gray-50'"
>
<DebugFailedTest
v-if="specData.failedTests[thumbprint].length >= 1"
Expand Down