-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: truncate text to fix layout #25270
fix: truncate text to fix layout #25270
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@elevatebart @marktnoonan Could you re-review this PR from @Manuel-Suarez-Abascal ? You both initially provided feedback on #24831 which was closed and replaced with this PR to fix the CLA issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Manuel-Suarez-Abascal & thank you for addressing the CLA issue, I think we actually need one other small CSS change to the same line to correct a spacing issue, then we can approve and merge. I'm made a comment with a padding change that works.
Co-authored-by: Stokes Player <stokes.player@gmail.com>
User-facing changelog
It truncates the browser name in the UI in order to avoid layout issues when the browser name is too long.
Additional details
N/A
Steps to test
How has the user experience changed?
An ellipsis will be added if the browser name is too long. Ellipsis will be added if the browser name is more than 16 characters.
PR Tasks
cypress-documentation
?type definitions
?