-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix windows-lint CI job #24758
fix: fix windows-lint CI job #24758
Changes from all commits
763974a
80a7d76
e9b6228
fcc475d
36ef6fc
375f736
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,6 @@ | |
|
||
*.json text eol=lf | ||
|
||
**/.eslintrc text eol=lf | ||
|
||
packages/errors/__snapshot-html__/** linguist-generated=true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,10 @@ | |
<script> | ||
export default { | ||
props: { | ||
msg: String, | ||
msg: { | ||
type: String, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this intended? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, this was to resolve one of the warnings that was showing up during linting just to clean some things up. It looks like ESLint requires a default for Vue props the way we have it configured, or else it warns. |
||
default: '', | ||
}, | ||
}, | ||
data () { | ||
return { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
**/tsconfig.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the change that makes the
windows-lint
job pass again