-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Styling of specs list at small breakpoints #22635
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better 👍🏻
@mike-plummer sorry for the suppppper slow review! |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Additional details
visibility
rather thandisplay
which caused layout space to be preserved while hiding the item visually when we actually wanted the item to be fully removed from the layout flow at the lower breakpoint. It was being correctly handled in the header but not in the row itemsButton
component's padding & icon size but that feels like a larger issue to be addressed with UXSteps to test
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation
?type definitions
?