Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Styling of specs list at small breakpoints #22635

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

mike-plummer
Copy link
Contributor

User facing changelog

  • Fix styling issues of Specs Explorer at narrow viewport widths

Additional details

  • Fix issue where spec rows aren't vertically centered at narrow viewport widths
    • This was caused by using CSS visibility rather than display which caused layout space to be preserved while hiding the item visually when we actually wanted the item to be fully removed from the layout flow at the lower breakpoint. It was being correctly handled in the header but not in the row items
  • Per product request, increase min width of "New Spec" button to prevent wrapping. We may want to look into responsively scaling the Button component's padding & icon size but that feels like a larger issue to be addressed with UX

Steps to test

  1. Open a project with specs in the Cypress app, navigate to Specs Explorer
  2. Narrow viewport to < 768px, observe spec rows remain vertically centered and button text does not wrap

How has the user experience changed?

Before
Screen Shot 2022-06-30 at 3 46 18 PM

After
Screen Shot 2022-06-30 at 3 45 47 PM

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 30, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 30, 2022



Test summary

9288 0 114 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 30dfaf4
Started Jul 15, 2022 12:25 AM
Ended Jul 15, 2022 12:40 AM
Duration 14:25 💡
OS Linux Debian - 10.11
Browser Firefox 98

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mike-plummer mike-plummer marked this pull request as ready for review July 1, 2022 14:11
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better 👍🏻

@emilyrohrbough
Copy link
Member

@mike-plummer sorry for the suppppper slow review!

@mike-plummer mike-plummer merged commit cb81596 into develop Jul 15, 2022
@mike-plummer mike-plummer deleted the 22626-specs-list-small-breakpoint branch July 15, 2022 00:37
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the specs list the vertical alignment of Specs is incorrect
3 participants